Bugfix RFLINK remove group#6580
Conversation
|
Thanks for jumping on this. I didn't have time to investigate it yet. However dropping 'automatic group adding' as a feature completely is the wrong direction for this component. The nature of these devices can cause a lot unwanted entries to appear if automatic detection is enabled (rflink devices from neighbors mostly). And not everyone might like to have to manually add all their devices to config (or have to change config/restart to detect new devices). What would be the best solution in line with best practices according to you? |
|
A reboot are not needed for group changes and now it could be done on UI. Devices are change not every day. So you need setup your stuff once and not setup every start. So it is not need on platform level too |
|
Makes sense. |
* Bugfix RFLINK remove group * Remove group hack from lutron too * fix tests * fix lint * fix lint
|
This PR broke the Lutron component. I wish I had a change to review and test. Seems like you removed setting entity_id by only setting object_id, which isn't enough. By the way, I disagree with the notion about auto-grouping. The way Lutron software works it effectively forces you to organize the devices into rooms (areas) and places in the room. This is already, thus, forcing you to create groups. That's also how it shows up in the Lutron software, and is self described by the XML file we parse on startup. Dropping that structure on the floor and forcing the user to recreate it seems counter-productive. If you want to add an option to turn-off the auto-grouping for those who want to go the manual route that's fine, but getting rid of this feature seems wrong. |
Description:
Remove Group hack from platforms. It is the only platform that do that with lutron. With new bootstrap it is not anymore supported. I try first a hack with set entity_id on it but that will not work.
We have a nice group editor and I don't think it is the task of platform to create groups. A platform should only setup the device to entity and don't things inside core. Lutron is the best example that it make to complex and lot of hacks for self grouping.
Related issue (if applicable): fixes #6571